Skip to content

chore: fixup data-testid order#3325

Merged
FRSgit merged 2 commits intov2-developfrom
fix/data-testid-order-in-vue
Nov 20, 2025
Merged

chore: fixup data-testid order#3325
FRSgit merged 2 commits intov2-developfrom
fix/data-testid-order-in-vue

Conversation

@FRSgit
Copy link
Copy Markdown
Contributor

@FRSgit FRSgit commented Nov 20, 2025

Related issue

Closes #

Scope of work

data-testid attribute should be specified before v-bind attr on the elements so it's possible to overwritedata-testid from the outside

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@FRSgit FRSgit self-assigned this Nov 20, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: 2523609

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@storefront-ui/vue Patch
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FRSgit FRSgit merged commit 023abe7 into v2-develop Nov 20, 2025
@FRSgit FRSgit deleted the fix/data-testid-order-in-vue branch November 20, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants